https://bugzilla.redhat.com/show_bug.cgi?id=1148224 Mukundan Ragavan <nonamedotc@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- $ diff -Nu ~/ownCloud/pkg_reviews/mmdb2/rev1/srpm-unpacked/mmdb2.spec mmdb2.spec --- /home/mukundan/ownCloud/pkg_reviews/mmdb2/rev1/srpm-unpacked/mmdb2.spec 2014-09-30 20:22:44.000000000 -0500 +++ mmdb2.spec 2014-11-13 20:50:19.000000000 -0600 @@ -1,7 +1,7 @@ Summary: Macromolecular coordinate library Name: mmdb2 Version: 2.0.1 -Release: 1%{?dist} +Release: 2%{?dist} License: LGPLv3 Group: System Environment/Libraries URL: ftp://ftp.ccp4.ac.uk/opensource/ @@ -53,31 +53,28 @@ make %{?_smp_mflags} %install -rm -rf %{buildroot} -make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' +make install DESTDIR=%{buildroot} INSTALL='install -p' # remove unpackaged files from the buildroot -rm -f $RPM_BUILD_ROOT%{_libdir}/*.la +rm -f %{buildroot}%{_libdir}/*.la %post -p /sbin/ldconfig %postun -p /sbin/ldconfig -%clean -rm -rf %{buildroot} - %files -%defattr(-,root,root,-) %doc AUTHORS COPYING README %{_libdir}/libmmdb2.so.0.0.0 %{_libdir}/libmmdb2.so.0 %files devel -%defattr(-,root,root,-) %{_libdir}/libmmdb2.so %{_includedir}/mmdb2/ %{_libdir}/pkgconfig/%{name}.pc %changelog +* Sun Nov 2 2014 Tim Fenn <tim.fenn@xxxxxxxxx> - 2.0.1-2 +- spec file clean ups/modernization + * Sun Sep 21 2014 Tim Fenn <tim.fenn@xxxxxxxxx> - 2.0.1-1 - Initial build Package builds fine in mock. No other issues in review. Package APPROVED. Cheers, and sorry for the delays. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review