Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: virt-manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226528 ------- Additional Comments From dlutter@xxxxxxxxxx 2007-05-03 18:03 EST ------- Review is based on http://koji.fedoraproject.org/packages/virt-manager/0.4.0/1.fc7/src/virt-manager-0.4.0-1.fc7.src.rpm Overall, specfile looks good, conforms with packaging guidelines rpmlint reports: W: virt-manager non-conffile-in-etc /etc/security/console.apps/virt-manager W: virt-manager non-conffile-in-etc /etc/gconf/schemas/virt-manager.schemas W: virt-manager non-conffile-in-etc /etc/pam.d/virt-manager The pam.d file should be marked as %config(noreplace); the others seem ok W: virt-manager symlink-should-be-relative /usr/bin/virt-manager /usr/bin/consolehelper Easy fix E: virt-manager explicit-lib-dependency librsvg2 It seems that that is ok; AFAICT, rpm won't be able to find this dependency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review