[Bug 1157908] Review Request: calamares - Installer from a live CD/DVD/USB to disk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1157908



--- Comment #9 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
OK, finally (sorry for the delay).

naming: ok

licensing: ok
$ licensecheck  -r src | cut -d: -f2 | sort | uniq
 GPL (v2 or later)
 GPL (v3 or later)
 LGPL (v2)
 *No copyright* UNKNOWN


1.  sources: NOT ok/verifiable, source URLS give 404s:
spectool -g *.spec
Getting
https://github.com/calamares/calamares/archive/faa77d7f5e65620212b6abcba9bc71e55bb78f4e/calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
to ./calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found
Getting
https://github.com/calamares/partitionmanager/archive/3f1ace00592088a920f731acb1e42417f71f5e62/calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz
to ./calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found


2. SHOULD:   I'd also prefer if you used something closer to the SourceURL
template on
https://fedoraproject.org/wiki/Packaging:SourceURL#Github
which has a shorter Release tag.


macros: ok

scriptlets: ok

%files: ok



I think the rest looks pretty good, please address item 1, and consider 2,
thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]