[Bug 1145100] Review Request: zeromq2 - Software library for fast, message-based applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1145100



--- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> ---
Many thanks for the review.

(In reply to Robin Lee from comment #3)
> [!]: Each %files section contains %defattr if rpm < 4.4
>      Note: %defattr present but not needed

removed

> ===== SHOULD items =====
> 
> Generic:
> [!]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)

Still no %clean there, as it is not needed anymore.


> ===== EXTRA items =====
> 
> Generic:
> [!]: Package should not use obsolete m4 macros
>      Note: Some obsoleted macros found, see the attachment.
>      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

sed'ed in %prep.


> AutoTools: Obsoleted m4s found
> ------------------------------
>   AC_PROG_LIBTOOL found in: zeromq-2.2.0/configure.in:55
>   AM_CONFIG_HEADER found in: zeromq-2.2.0/configure.in:13

see above

> ===== Extra items ======
> [!] zeromq2-devel should also conflict zeromq3-devel
> [!] Summary and description should reflect that this package is for ZeroMQ 2.

both fixed.

changelog:
- cleaning ups according to review (#1145100)
- remove %%defattr
- mention version 2 in summary and description
- remove obsolted autotools m4s


Spec URL: http://tomspur.fedorapeople.org/review/zeromq2.spec
SRPM URL: http://tomspur.fedorapeople.org/review/zeromq2-2.2.0-12.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]