[Bug 1163612] Review Request: asql - run SQL queries against an Apache log file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1163612



--- Comment #1 from William Moreno <williamjmorenor@xxxxxxxxx> ---
Hi Wilfredo this is a informal review, if this is your firts package.

These are some points than still need atention:

1- asql.noarch: W: spelling-error Summary(en_US) logfile -> log file,

Please check spelling in the Spec.

2- asql.noarch: W: summary-not-capitalized C asql allows you to run SQL
queries against an Apache logfile.

Sumary must be capitalidez

3- asql.noarch: W: summary-ended-with-dot

Sumary do not require dot (.) at end

4- asql.noarch: W: name-repeated-in-summary 

Summary do not need to have the package name

5- asql.noarch: W: spelling-error %description -l en_US logfile -> log
file

Same than point 1

6- asql.noarch: W: incoherent-version-in-changelog 0.0.1-1 ['1.7-1.fc20

Versión in changelog must the same version of the package

7- asql.noarch: W: invalid-license Artistic

It is a apache script, can you use GPL? Remember to update the pach with the
lincese file

8- asql.noarch: W: no-manual-page-for-binary asql

This is not a bloqquer but binary files need a manpage, please open a Bug in
upstream and request to include manpage

9- [!]: Spec file according to URL is the same as in SRPM

Spec file in url is not the same Spec file used to build the rpm, please update
our spec and remake the rpm. Remenber to bump the relesease numbre to 2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]