Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hippo-canvas - Crossplatform canvas using cairo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235741 ------- Additional Comments From mclasen@xxxxxxxxxx 2007-05-03 13:44 EST ------- rpmlint output: E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/AUTHORS E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/README W: hippo-canvas-devel no-documentation W: hippo-canvas-python no-documentation Package name: ok Spec file name: ok Packaging guidelines: ok, just some cosmetic things: - Descriptions should be full sentences ending in a .. - Typo: "multipul" should be "multiple" License: ok, I assume. But I wonder why you need any of the "mugshot trademark" stuff in this package. Wouldn't it be easier to just make this straight GPL, since there is no actual "Mugshot" in this package, it is just a canvas... License file included: ok Spec file language and clarity: excellent Upstream source: ok Package build: Missing BRs: pygtk2-devel, pycairo-devel Relocatable: n/a Directory ownership: ok File lists: ok %clean section: ok Macro use: ok Content: ok Large docs: n/a %doc files: AUTHORS and README are empty, so either remove them or (better) put something in them. Headers: ok pc file: n/a shared libs: ok static libs: n/a -devel dependencies: ok .la file: ok .desktop files: n/a %install section cleans buildroot: ok filename encoding: ok -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review