[Bug 1162303] Review Request: kde-plasma-redshift - Plasmoid for redshift

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1162303



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
Some initial comments,

1. SHOULD use
BuildRequires: kdelibs4-devel
(instead of kdelibs-devel, in case kdelibs-devel ever moves to v5)

2. in %files SHOULD use
%{_kde4_iconsdir}/hicolor/*/*/*
instead
and relatedly...

3. MUST include icon cache scriplets per
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]