https://bugzilla.redhat.com/show_bug.cgi?id=1162076 --- Comment #1 from Mihkel Vain <turakas@xxxxxxxxx> --- Ok. A few notes first. > Group: Amusements/Games This is not required anymore, unless you plan to target EL5 > %doc %{_docdir}/tuxanci-%{version} I think you should include bundled README, LICENSE and AUTHORS file in doc like this: > %doc README LICENSE AUTHORS No need for %{_docdir}/tuxanci-%{version} under %files section rpmlint output: Checking: tuxanci-0.21.0-1.fc20.x86_64.rpm tuxanci-0.21.0-1.fc20.src.rpm tuxanci.x86_64: W: spelling-error Summary(en_US) multiplayer -> multiplier, multiplexer tuxanci.x86_64: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer tuxanci.x86_64: E: incorrect-fsf-address /usr/share/doc/tuxanci-0.21.0/LICENCE tuxanci.x86_64: W: no-manual-page-for-binary tuxanci-0.21.0 tuxanci.x86_64: W: no-manual-page-for-binary tuxanci tuxanci.x86_64: E: invalid-appdata-file /usr/share/appdata/tuxanci.appdata.xml tuxanci.src: W: spelling-error Summary(en_US) multiplayer -> multiplier, multiplexer tuxanci.src: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer 2 packages and 0 specfiles checked; 2 errors, 6 warnings. Spelling look correct to me, so we can ignore those. Manual pages are SHOULD according to packaging guidelines, but not a blocker. $ appdata-validate --relax 1162076-tuxanci/srpm-unpacked/tuxanci.appdata.xml also return no errors, so I don't know why rpmlint reports about invalid-appdata-file. This should be ok too. But this one: tuxanci.x86_64: E: incorrect-fsf-address /usr/share/doc/tuxanci-0.21.0/LICENCE https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address You must inform upstream about that, but I think this is not a blocker either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review