https://bugzilla.redhat.com/show_bug.cgi?id=1159873 --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok license: ok, but could be ammended to License: LGPLv2+ sources: ok 2d2c2251659f285031f65bfb30c741c3 lxqt-panel-0.8.0.tar.xz macros: ok scriptlets: ok (n/a) 1. SHOULD omit Obsoletes: lxpanel until an upgrade path/plan is agreed upon 2. SHOULD omit -devel dependencies: Requires: pkgconfig(Qt5Widgets) Requires: pkgconfig(Qt5DBus) Requires: pkgconfig(Qt5Help) Requires: pkgconfig(Qt5Xml) Requires: pkgconfig(Qt5X11Extras) Requires: pkgconfig(lxqt-qt5) Requires: pkgconfig(lxqtmount-qt5) Requires: pkgconfig(lxqt-globalkeys-qt5) Requires: pkgconfig(lxqt-globalkeys-ui-qt5) these ought to get detected automatically from included .pc files already 3. MUST own %{_libdir}/lxqt-panel/ dir (unless something else owns it?0 4. %files devel %{_includedir}/lxqt headers only, no libs? If so, could consider making this subpkg noarch or simply not ship these at all for now. Please fix at least the MUST blocker items, and give fresh spec/srpm links -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review