[Bug 1158625] Review Request: lxqt-mount - Mount library utility for LXQt desktop Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1158625

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
naming: ok

license: ok, but could be ammended to
License: LGPLv2+

sources: ok
0d12418bb26fb4f630895231e5ecaffb  liblxqt-mount-0.8.0.tar.xz

macros: ok

scriptlets: ok


1. SHOULD omit explicit -devel deps:
Requires: pkgconfig(Qt5Core)
Requires: pkgconfig(Qt5Gui)
Requires: pkgconfig(Qt5DBus)
Requires: pkgconfig(Qt5Help)
these should get detected automatically via included .pc files already



APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]