[Bug 1159829] Review Request: lxqt-openssh-askpass - Askpass openssh transition dialog for LXQt desktop suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1159829

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
naming: ok

license: ok, could be ammended to
License: LGPLv2+

sources: ok
74e0fd9f684b4e855ea1c5accbd64d10  lxqt-openssh-askpass-0.8.0.tar.xz

macros: ok

scriptlets: ok (n/a)


thanks for moving to libexecdir, not sure if it's worth worrying about what
happens when > 1 openssh-askpass provider is installed, and they stomp on each
others' SSH_ASKPASS= env assignments, but I suppose that's outside the purview
of this review


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]