[Bug 1158996] Review Request: lxqt-qtplugin - Qt plugin framework for LXQt Desktop Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1158996

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
naming: ok

sources: ok
eac15139d7d0732592ac00a225ed7cfc  lxqt-qtplugin-0.8.0.tar.xz

license: ok, but could ammend to
License: LGPLv2+

macros: ok

scriptlets: ok, n/a


1. SHOULD update %files to use %_qt5_plugindir macro, instead of:
%{_libdir}/qt5/plugins/platformthemes//libqtlxqt.so
use
%{_qt5_plugindir}/platformthemes/libqtlxqt.so


another clean and simple packaging specimen, 
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]