[Bug 1155829] Review Request: openvas-gsa - Greenbone Security Assistant (GSA) is GUI to the OpenVAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1155829



--- Comment #5 from Michal Ambroz <rebus@xxxxxxxxx> ---
SPEC: http://rebus.fedorapeople.org/SPECS/openvas-gsa.spec
SRPM: http://rebus.fedorapeople.org/SRPMS/openvas-gsa-5.0.4-2.fc20.src.rpm

Hello Xavier,
thanks for having a look.

- removed sysvinit support
- added setgroups patch as noted by the rpmlint
- fixed encoding problems for the changelogs
- marked logrotate script as config

>- Summary could be : "OpenVAS graphical user interface",
> it seems clearer and doesn't repeat the package name.
I already renamed from greenbone-security-assistant to openvas-gsa to keep the
openvas naming convention. I agree shorter name would be nice, but I believe
the Greenbone deserves its name at least in the summary. That way it makes it
also easier to be searched by "yum search"

>- %{_sysconfdir}/openvas/ is not owned.
It is owned by openvas-libraries, which is in the requirements of this package.
This is aligned with:
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

>It seems the disabled patch2 deals with the first rpmlint warning,
>but as it's not applied nor included, I can't tell for sure.
I was already trying, but didn't know the proper syntax required. Now it should
be ok.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]