https://bugzilla.redhat.com/show_bug.cgi?id=1161126 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 7905d7752f0afedca0d6a0f008b8b489519c0b01dedc50de1fcce74520253cc0). Ok. License verified from README and lib/Config/AutoConf.pm. Ok. Summary verified from lib/Config/AutoConf.pm. Ok. TODO: Spell `perl' with uppercase initial letter in the summary. Description verified from lib/Config/AutoConf.pm. Ok. File::Slurp::Tiny is optional. Ok. Scalar::Util is optional. Ok. IO::String needed only for old perls. Ok. TODO: Build-require and run-require `glibc-headers' because the code tries to compile a code with `#include <stdio.h>' text etc. (lib/Config/AutoConf.pm:2375) All tests pass. Ok. $ rpmlint perl-Config-AutoConf.spec ../SRPMS/perl-Config-AutoConf-0.305-1.fc22.src.rpm ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Nov 6 16:58 /usr/share/doc/perl-Config-AutoConf -rw-r--r-- 1 root root 6346 Jun 12 20:18 /usr/share/doc/perl-Config-AutoConf/Changes -rw-r--r-- 1 root root 560 Apr 7 2014 /usr/share/doc/perl-Config-AutoConf/README -rw-r--r-- 1 root root 9834 Nov 6 16:57 /usr/share/man/man3/Config::AutoConf.3pm.gz drwxr-xr-x 2 root root 0 Nov 6 16:57 /usr/share/perl5/vendor_perl/Config -rw-r--r-- 1 root root 71147 Jun 12 20:18 /usr/share/perl5/vendor_perl/Config/AutoConf.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(base) 1 perl(Capture::Tiny) 1 perl(Carp) 1 perl(Config) 1 perl(constant) 1 perl(Exporter) 1 perl(ExtUtils::CBuilder) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(strict) 1 perl(Text::ParseWords) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Config::AutoConf) = 0.305 1 perl-Config-AutoConf = 0.305-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8055853). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review