https://bugzilla.redhat.com/show_bug.cgi?id=1155829 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- No formal review yet, but a couple comments : - Summary could be : "OpenVAS graphical user interface", it seems clearer and doesn't repeat the package name. - The sysvinit subpackage is only relevant for EL5 and EL6. It might be better to build either sysvinit or systemd depending on the target OS. Also I think the (Build)Requires on systemd would fail on EL5/EL6 and the %{_unitdir} will be undefined. - There's a disabled patch (Patch2). - Typo : "# Log direcotry" --> "# Log directory". - %{_sysconfdir}/openvas/ is not owned. - Nitpick : Add a / at the end of the following line in the %files section to make it even more obvious it is a directory : %dir %{_localstatedir}/log/openvas -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review