[Bug 1146933] Review Request: fontdump - Dump the CSS and different formats offonts for Google Fonts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1146933

Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> ---
(In reply to Parag from comment #4)
> (In reply to Eduardo Mayorga from comment #3)
> > [!]: If (and only if) the source package includes the text of the license(s)
> >      in its own file, then that file, containing the text of the license(s)
> >      for the package is included in %doc.
> 
>   I don't see this as a Fail item as source archive does not contain any
> license file.

Right, the tarball in PyPI does not include the license file, but it's shipped
in the tarballs from Github.

> > [!]: Large documentation must go in a -doc subpackage. Large could be size
> >      (~1MB) or number of files.
> >      Note: Documentation size is 10240 bytes in 1 files.
> 
> 
> This package only have (kind of generic) PKG-INFO (size 4636 bytes) as a
> %doc file which many other python packages already included but I have not
> seen this single file being packaged in -doc subpackage. You sure you want
> me to add this PKG-INFO in -doc ?

As warned by fedora-review, I marked this item as fails. Ignore this, the note
was a false positive.

> > [!]: Description and summary sections in the package spec file contains
> >      translations for supported Non-English languages, if available.
> 
>      I am not sure how I can fix this. Can you help me for this?

See this example for Spanish:
http://pkgs.fedoraproject.org/cgit/hyena.git/tree/hyena.spec#n6

Now it looks good.

PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]