[Bug 1157700] Review Request: php-ocramius-code-generator-utils - A set of code generator utilities built on top of PHP-Parsers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1157700



--- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to Remi Collet from comment #3)
> Minor cleanup (no blocker)
> 
> - ensure you use the correct spec (see review.txt) without the debug "find"

Oooops, my bad.  That was a debug b/c of an issue w/ the previous PHPParser
release.

> - consider to silent the include (in test autoloader) to avoid some warning
> at build time

I'm not sure how that un-silenced.  Perhaps during my debug.

> Everything seems OK.
> 
> === APPROVED ===

I'll make sure everything is cleaned up after initial import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]