https://bugzilla.redhat.com/show_bug.cgi?id=1159873 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Very quick look at your spec file: * Please check if the license tag should "LGPLv2" or "LGPLv2+" see: https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F * Basically dependency for packages made from the same srpm should be isa specific https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requires_2 * Please explain where lots of "Requires (not BuildRequires): pkgconfig(foo)" in -devel package comes from - Note that if the package contains pkgconfig .pc files, dependency for such pkgconfig files are automatically generated on rpmbuild process so usually no need to explicitly write them. Anyway pkgconfig(foo) is meant for pkgconfig file related dependency and currently I don't see such Requries is needed for lxqt-panel-devel package * Please beaware of directory ownership issue https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership - Please check the ownership of - {_libdir}/lxqt-panel/ - What owns %{_sysconfdir}/xdg/lxqt/ ? - It seems that multiple package owns - %{_datadir}/lxqt-qt5 - %{_includedir}/lxqt Please examine which package should own these directories and fix files lists properly * Files under /etc is configuration files and should be marked as %config(noreplace) http://www.pathname.com/fhs/pub/fhs-2.3.html#ETCHOSTSPECIFICSYSTEMCONFIGURATION https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Configuration_files * Why does this package obsoletes gtk version lxpanel? It should be parallel installable and this should not obsolete lxpanel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review