[Bug 1060419] Review Request: gwakeonlan - A GTK+ utility to awake machines using the Wake on LAN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1060419



--- Comment #13 from nicolas.vieville@xxxxxxxxxxxxxxxxxxxx ---
(In reply to Alberto Chiusole from comment #12)

Hello,

> I've followed all your tips and I've uploaded the new version of SRPM, along
> with the new package (0.6.2). Here are the:
> * SPEC: http://rpm.bebosudo.tk/SPECS/gwakeonlan.spec
> * SRPM: http://rpm.bebosudo.tk/SRPMS/gwakeonlan-0.6.2-1.fc20.src.rpm

Thank you for these new files. Sorry for the delay.

> I've used tabs because I personally prefer those, and I followed all your
> other tips. thanks again.

Yes it's a matter of taste. Personally, I use spaces because I know that
formatted text will be respected independently from the tabulation width
settings in editors. But Fedora packaging rules let packagers do what they want
on this point, so that's perfect.

> rpmlint doesn't complaint about nothing, so I think we're doing quite good.
> $ rpmlint -i gwakeonlan.spec ../SRPMS/gwakeonlan-0.6-*fc*.src.rpm
> ../RPMS/noarch/gwakeonlan-0.6-*.fc*.noarch.rpm
> 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
> $

Strange, for my part I've got:

rpmlint gwakeonlan-0.6.2-1.fc20.src.rpm 
gwakeonlan.src: W: strange-permission gwakeonlan.spec 0777L
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Please could you modify gwakeonlan.spec file permissions to 0644?

I'll post the commented fedora-review result once you fix this little problem.

> What do we have to do now? There is the need of a proven packager, am I
> right?

Yes, you are right. And maybe a sponsor too :)

> Have a nice day!

Thank you. You too.

Regards,


-- 
NVieville

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]