https://bugzilla.redhat.com/show_bug.cgi?id=1157402 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|extras-qa@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- I can start the formal review: 1. License: LGPL-2.1+ NOT ok, MUST use one listed on https://fedoraproject.org/wiki/Licensing probably want License: LGPLv2 2. MUST drop extraneous -devel dependency BuildRequires: pkgconfig(Qt5Xdg) >= 1.0.0 it is already list in the main package (no need to duplicate it here) 3. SHOULD not use %make_install macro (it's only compatible with very recent rpm versions, certainly not centos6), I'd recommend using instead: make install/fast DESTDIR=%{buildroot} -C build 4. SHOULD not omit translation, rm -f %{buildroot}/%{_datadir}/lxqt-qt5/translations/liblxqt/liblxqt_sr@xxxxxxxx or at least provide justification why. 5. SHOULD track library soname, instead of %{_libdir}/liblxqt-qt5.so.* use %{_libdir}/liblxqt-qt5.so.0* (this will give you warning when incompatible library versions land when updating the package) I'd encourage you to consider adopting something close to helio's version, it does not suffer any of these issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review