[Bug 1151816] Review Request: nodejs-replace - Command line search and replace utility using Nodejs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1151816

Lubomir Rintel <lkundrak@xxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak@xxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |lkundrak@xxxxx
              Alias|                            |nodejs-replace
              Flags|                            |fedora-review?



--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> ---
* Named correctly
* Versioned correctly
* Latest version packaged
* License tag correct
! License text not included
* License good for fedora
* SPEC file clean and legible, follows nodejs guidelines
* Filelist sane
* Requires/provides make sense
* rpmlint happy

Please drop the LICENSE file from another package, it's of no use.

Looking at the upstream GitHub project it seems that the maintainer is more
likely to merge a pull request than respond to a bug report? I'm wondering if
you could do a pull request instead and explain why is it important to ship the
license text in the commit message?

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]