Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TastyMenu - KMenu replacement aiming to provide the maximum usability Alias: tastymenu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238235 ------- Additional Comments From chris.stone@xxxxxxxxx 2007-05-01 19:57 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output: W: tastymenu dangling-relative-symlink /usr/share/doc/HTML/en/tastymenu/common ../common This is okay, package requires kdelibs which owns this file. - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license field matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream d58492c17fe97615e912d28399fce2ef tastymenu-0.8.tar.bz2 - successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - locales handled properly - no shared library in default path - package not relocatable - package owns all directories it creates X package Requires packages to bring in all other used directories - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - contains code - no large documentation - files in %doc do not affect runtime - no header files - no static libraries - no pkgconfig files - no library with suffix - no need for devel subpackage - package contains libtool archive This is a KDE package which is an exception to the .la requirement - contains proper .desktop file - package does not own files or directories owned by other packages - contains proper %install - all filenames valid utf-8 ==== MUST FIX ===== - Add: Requires: kdebase This brings in the /usr/share/apps/kicker/applets/ directory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review