[Bug 1155400] Review Request: pygeoip - Pure Python GeoIP API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1155400



--- Comment #7 from nicolas.vieville@xxxxxxxxxxxxxxxxxxxx ---
Hello William,

If you want to make the git repo the source of this package, some modifications
on your spec file are needed.

I would suggest that you modify this line:

%global pypi_name pygeoip

to:

%global git_name pygeoip
%global commit 7501c9327fc80e78be3f44585395e30141d8c749
%global shortcommit %(c=%{commit}; echo ${c:0:7})

Then, in order to take this in account, you should modify this line:

Source0:          
https://pypi.python.org/packages/source/p/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

to:

Source0:           
https://github.com/appliedsec/pygeoip/archive/%{commit}/%{git_name}-%{commit}.tar.gz

The pypi_name macro have to be renamed git_name in the entire spec file too.

the setup line in the %prep section have to be modify from:

%setup -q -n %{pypi_name}-%{version}

to:

%setup -qn %{git_name}-%{commit}

As you want to include the provided documentation, and as this one is build
with sphinx, then you should keep the required packages in the BuildRequires.

But sphinx provides a static bundled jquery.js file. So one have to add:

Provides:           bundled(jquery)

in each part describing the separates docs packages. See here for some
explanations:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_temporary_exceptions

Rpmlint continues to warn about wrong-file-end-of-line-encoding for this file,
but this seems to be okay as it is a one-line optimized jscript file.

In order to make it easier for you to apply these modifications, I will attach
a patch against your last spec file containing all the suggestion I made. Feel
free to use any part of it you think useful.

Don't hesitate to ask me for any help if needed.

Cordially,


-- 
NVieville

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]