[Bug 1155400] Review Request: pygeoip - Pure Python GeoIP API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1155400



--- Comment #5 from nicolas.vieville@xxxxxxxxxxxxxxxxxxxx ---
Hello,

You are right. I've missed that.

It could be possible to include the test archive as a source, but 18,139,571
bytes are probably too much (need more doc searching here). I'll probably try
to search about that in the next few days, but if on your side you find
something interesting about this subject, I really appreciate you post the
links you find.

As a proposition, I provided a patch against your spec file including all the
"glitches" I noticed previously. Feel free to use it or only pick what you
think interesting in it.

I think it should be worth verifying that python-sphinx (respectively
python3-sphinx) included in the BuildRequires sections of your new spec file is
(are) really useful. I'm probably wrong, but I thought that sphinx was used to
build some documentation, and as you Source0 points to https://pypi.python.org
and this archive doesn't contain any docs folder, may be you should drop these
BuildRequires. If you choose to take in account as a Source0 file, the provided
archive on github, and as this one includes a docs directory needing sphinx in
its Makefile, then this dependency should be kept. 
But in this case, you should probably have to split this documentation in a
separate python-pygeoip-doc.noarch package from your spec file.

Hope this help.

Any comment are welcome.

I'll let you know in the next few days if I find something about the first
point of this message.

Cordially,


-- 
NVieville

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]