[Bug 1154213] Review Request: python-structlog - Painless structural logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1154213



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---


Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as sha256sum
srpm tarball: 45a6e7ba0e1f335822cf24e14b95d9590fe13e9e2a6abe58a099638037e84377
upstream tarball:
45a6e7ba0e1f335822cf24e14b95d9590fe13e9e2a6abe58a099638037e84377

+ License is ASL 2.0 and included in LICENSE file

+ follow python packaging guidelines

Suggestions:
1) Group tag is optional

2) License tag is missing for python3-structlog sub-package

3) %files section should be more verbose like in your other approved packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]