[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080411

Karel Volný <kvolny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(i@xxxxxxxx)



--- Comment #14 from Karel Volný <kvolny@xxxxxxxxxx> ---
oops, this took longer than expected :-(

here's the new version:

Spec URL: http://kvolny.fedorapeople.org/trojita.spec
SRPM URL: http://kvolny.fedorapeople.org/trojita-0.4.1-3.fc20.src.rpm

it only adds ragel dependency ...

0) "above issues" - I see just

[!]: Package does not own files or directories owned by other packages.

- anything else?

as for the icon dirs ownership, I've already responded in comment #4 and after
re-reading
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
I believe not requiring otherwise unneeded package is the correct solution

1) ragel is now used

2) following the discussion in comment #10, I believe it is better not to mess
with it; when I've done my testbuild, tests took just 11 seconds so there's not
much to gain here

3) appdata got added upstream:

http://quickgit.kde.org/?p=trojita.git&a=commit&h=66cf5af897741d9655c2836ce1e5db2c22c8636d

so I'd prefer to just wait for the next version and pick it up from the
upstream tarball rather than to add own copy now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]