https://bugzilla.redhat.com/show_bug.cgi?id=1156659 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Raphael Groner <projects.rg@xxxxxxxx> --- > [?]: Sources contain only permissible code or content. > ++ I don't have the time to read the code details, besides am no owner of > any INDI devices. You did not comment on that. Honestly, I do worry about shipping dead code, at least in the SRPM. Consistently thinking, I am talking about the platform specific conditionals and so any code - but as far as I understand now that dead code will in Fedora never be used but still shipped !! - in CMakelists.txt content and also the CPack logic. It may confuse when you look at the code and it is just NOOP over several lines. Please try to sort things out with help from upstream. If upstream wants still to keep going with CPack, the maintainer should really think about also using CPack for packaging what would IIRC bring feature conflicts to rpmbuild. CMake was designed to generate makefiles dynamically. Why do we need that again on the meta level to generate also dynamic CMake configuration, I don't understand, sorry. It should be the job of CMake itself and already to care about platform specific stuff, doesn't it? IMHO it's the job of the packager/maintainer to care about the packaging logic, also CMake from upstream with maybe needed patches from downstream (Fedora). When upstream is too lazy for caring about possible downstream, better ignore them, there you are right but still what then to do with dead and not needed code, just remove it by patch. That's how I understand Fedora policy. As the other points with originally [?] are considered, those are now {x]. Therefore, I think the package is ACCEPT. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review