[Bug 1155495] Review Request: python-yappi - Yet Another Python Profiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1155495

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |piotr1212@xxxxxxxxx



--- Comment #2 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
Some comments:

Errors:
- spec filename does not match package name, rename yappi.spec to
python-yappi.spec
- Source0 url gives 404:
https://pypi.python.org/packages/source/y/yappi/1d187cc9e455d3d11915da135937fe8bcf502c4b.tar.gz
- No files markes as %doc. Add "%doc README.md LICENSE" to %files section
- mock build fails missing BuildRequires. Add BuildRequires: python-setuptools


Suggestions:
- %description is a bit long and is more a motivation than description.
- Could you add a python3 module?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]