https://bugzilla.redhat.com/show_bug.cgi?id=1156657 --- Comment #5 from Christian Dersch <chrisdersch@xxxxxxxxx> --- (In reply to Christian Dersch from comment #4) > Thank you for your fast review Raphael :) > (In reply to Raphael Groner from comment #3) > > > [x]: Package is licensed with an open-source compatible license and meets > > other legal requirements as defined in the legal section of Packaging > > Guidelines. > > ++ If the source package does not include the text of the license(s), the > > packager should contact upstream and encourage them to correct this mistake. > > Please do so. > > The package contains a copy of the GPLv3+ in LICENXE.txt > > > [?]: Package consistently uses macros (instead of hard-coded directory > > names). > > ++ This is not fully clear. I don't understand why you use macros sometimes > > and sometimes not. See also my initial comments about that. > > What does "consistently" mean for you? Just as a warning to keep potential > > upwards compatibility if folder standards change or the like. > > I can change this if neccessary (you mean the sed command i think) > I had another review in mind (indi-sx), so please explain where I miss usage of macros. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review