[Bug 1154743] Review Request: python-pretend - A library for stubbing in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1154743

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) The given spec file and spec file packaged in SRPM is not same, I guess its
some whitespace issue. correct this by having same spec packaged in srpm.

2) Group tag is optional in fedora releases. You may want to remove it but not
mandatory

3) you should add license tag for python3-pretend also.

4) Its a good practice to remove any upstream supplied egg-info files in %prep
and have packaged the newly generated egg-info files.

rm -rf *.egg-info

Otherwise package looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]