https://bugzilla.redhat.com/show_bug.cgi?id=1156657 --- Comment #2 from Christian Dersch <chrisdersch@xxxxxxxxx> --- (In reply to Raphael Groner from comment #1) > > # Post-Release checkout containing some improvements > > Release: 1.%{checkout}%{?dist} > You should better use a timestamp additionally for a snapshot release > independently of pre/post-release logic. Cause if your checkout changes, you > would have to increase the main number also: > Release: 1.20141025svn%{checkout}%{?dist} > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages > You didn't really read and understand the spec, %{checkout} contains the timestamp as well as the revision exactly in same format you want to see here... > > > %install > > make install DESTDIR=%{buildroot} > %make_install > Please comment why you prefer DESTDIR usage. > https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_. > 25makeinstall_macro_should_not_be_used I cite your link "Instead, Fedora packages should use: %make_install (Note the "_" !), make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install. Those all do the same thing." So the spec is fine in this case ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review