https://bugzilla.redhat.com/show_bug.cgi?id=1156659 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- > # Post-Release checkout containing some improvements > Release: 1.%{checkout}%{?dist} You should better use a timestamp additionally for a snapshot release independently of pre/post-release logic. Cause if your checkout changes, you would have to increase the main number also: Release: 1.20142510svn%{checkout}%{?dist} https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages > # For Fedora we want to put udev rules in %{_udevrulesdir}/ > sed -i 's|/lib/udev|/usr/lib/udev|g' CMakeLists.txt Why don't you use the macro then directly in the sed command line as you already do in %files? Please change that to not confuse with the comment. > %install > make install DESTDIR=%{buildroot} %install %make_install Please comment why you prefer DESTDIR usage. https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review