https://bugzilla.redhat.com/show_bug.cgi?id=1142051 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- > %check > %nodejs_symlink_deps --check This is pointless unless you actually execute something below it. For extra credit please add "BuildRequires: proof" and the test command `proof test */*/*.t.js` and comment it out or disable it all with a macro. This way, the tests can be easily enabled later on if someone packages proof. Everything else is legit and test issues are a SHOULD so APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review