https://bugzilla.redhat.com/show_bug.cgi?id=1155240 --- Comment #1 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Review: - you could install utils to e.g. /usr/share/gr-rds - you should create doc and devel subackages (you can copy&paste this from e.g. gr-iqbal or other gr-* spec files) - it's GPLv2+ or GPLv3+. I am able to find there GPLv3+ licensed code/scripts snips from gnuradio, thus the final package should be probably licensed under GPLv3+. If unsure, you can consult this with upstream. - no macros in comments, e.g. %{name} and more, please escape them with %, i.e. %%{name} - non-executable-script /usr/lib64/python2.7/site-packages/rds/rdspanel.py 0644L /usr/bin/env please filter out the hashbangs for python libs under site-packages - incorrect-fsf-address in /usr/include/rds/gnuradio/rds/data_encoder.h and in more files please notify upstream to correct the address - there is library, you need to run /sbin/ldconfig in %post and %postun - invalid-url Source0: gr-rds-20141006git841b6307.tar.xz please add URL from packaging guidelines [1] (you can copy&paste this from e.g. gr-fcdproplus package) - unused-direct-shlib-dependency /usr/lib64/libgnuradio-rds-0.1.1git.so.0.0.0 /lib64/libboost_filesystem.so.1.54.0 please link with -Wl,--as-needed [1] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review