https://bugzilla.redhat.com/show_bug.cgi?id=1015867 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx --- Comment #12 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + package built fine in mock rawhide(x86_64) - rpmlint on generated rpms gave output conky-manager.src: W: strange-permission conky-manager_2.2~118~ubuntu14.04.1.tar.gz 0640L conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/view-preview.svg conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/help-info.svvg conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/donate.svg conky-manager.x86_64: E: script-without-shebang /usr/share/conky-manager/images/view-list.svg conky-manager.x86_64: W: no-manual-page-for-binary conky-manager conky-manager-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 5 errors, 2 warnings. + Source verified with upstream as (sha256sum) upstream tarball: 8ee789d56a42d178a7c69b24c7e099c27592d088fef4a07ccdf8439598a9dba5 srpm tarball: 8ee789d56a42d178a7c69b24c7e099c27592d088fef4a07ccdf8439598a9dba5 + License is "GPLv3+" and its text is included in vala source headers as GPLv2+ and in COPYING as GPLv3+ Suggestions: 1) Group tag is optional for Fedora and can be removed 2) Patch0 should be written below source0 line 3) patch name should always be start like %{name}-%{version}-desktopentry-fixer-and-arabizer.patch 4) in %prep, good to add patch level also %patch0 -p0 5) To preserve the timestamp of upstream files getting installed directly use make install DESTDIR=%{buildroot} INTALL="install -p" 6) following lines should be at the end of %install section not in the middle desktop-file-install %{buildroot}/%{_datadir}/applications/conky-manager.desktop %find_lang %{name} 7) desktop-file-install when used should use --dir option see the usage as given in https://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage 8) in %files section instead of following 2 lines %{_datadir}/conky-manager/images/ %{_datadir}/conky-manager/themepacks/ just write %{_datadir}/conky-manager This will make sure this package will also own directory /usr/share/conky-manager 9) The MimeType in desktop file is kept empty. Check with upstream to remove it or you can remove it using sed -i '3d' conky-manager.desktop Reason I am asking this is if there is MimeType then we need to add update-desktop-database scriptlet 10) fix any other rpmlint message submit new srpm for further review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review