[Bug 1140195] Review Request: Paper Shaper - Provides random wallpaper from webcams or saved images or both

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1140195



--- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Who is pkcarlisle-dot-com behind?

Write it more as a real name in all places, in the bugzilla account
preferences, in the spec file %changelog: "P.K. Carlisle" would be one expected
way to write it. Don't use "pkcarlisle-dot-com" even if it resembles your full
name.


> I really can't figure out what this package is. It violates FHS as well:

It doesn't even build. That's no surprise, because no source code archive is
included. The spec file accesses paths/files not included in the src.rpm.

As a minimum, people who submit packages for review should examine a few Fedora
packages (via src.rpms or git) and follow well-known documentation:

  https://fedoraproject.org/wiki/Category:Package_Maintainers

Notice the index at the bottom.


> Buildroot: %{_sourcedir}

I would estimate that none of the many thousand Fedora (and Red Hat) packages
does it like that, especially since the purpose of the "Buildroot" is a
different one and clearly _not_ the same as %_sourcedir. Nowadays, one doesn't
set this tag anymore, btw:

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]