https://bugzilla.redhat.com/show_bug.cgi?id=1036354 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + package built fine in mock rawhide(x86_64) - rpmlint on generated rpms gave output nodejs-codemirror.noarch: W: incoherent-version-in-changelog 3.20.0-1 ['4.6.0-1.fc22', '4.6.0-1'] nodejs-codemirror.noarch: W: only-non-binary-in-usr-lib nodejs-codemirror.noarch: E: script-without-shebang /usr/lib/node_modules/codemirror/mode/dylan/index.html nodejs-codemirror.noarch: E: script-without-shebang /usr/lib/node_modules/codemirror/addon/hint/html-hint.js nodejs-codemirror.noarch: E: script-without-shebang /usr/lib/node_modules/codemirror/bin/authors.sh nodejs-codemirror.src: W: strange-permission codemirror-4.6.0.tgz 0640L 2 packages and 0 specfiles checked; 3 errors, 3 warnings. + Source verified with upstream as (sha256sum) upstream tarball:c7d089b5ebec55fb9edbb05090f2ffc66b950018607fdc2c2d01678c483def87 srpm tarball:c7d089b5ebec55fb9edbb05090f2ffc66b950018607fdc2c2d01678c483def87 + License is "MIT" and its text is included in LICENSE Suggestions: 1) Fix the rpmlint message of changelog version and then manually change the tarball permission from 0640 to 664 and then create srpm. Also, shebang issues. See 2) Group tag is optional and you may want to remove it for Fedora releases 3) change BuildRequires: nodejs-devel to BuildRequires: nodejs-packaging 4)I don't think you need following in spec so remove it %{?nodejs_find_provides_and_requires} 5) Its general practice to use in %prep rm -rf node_modules Please submit updated srpm for further package review. Also do read https://fedoraproject.org/wiki/Packaging:Node.js -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review