https://bugzilla.redhat.com/show_bug.cgi?id=1051840 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + package built fine in mock rawhide(x86_64) + rpmlint on generated rpms gave output python-libqutrub.noarch: W: spelling-error Summary(en_US) conjuagtion -> conjugation, conjuration, continuation python-libqutrub.noarch: I: enchant-dictionary-not-found ar python-libqutrub.noarch: W: spelling-error %description -l en_US conjuagtion -> conjugation, conjuration, continuation python-libqutrub.noarch: W: no-documentation python-libqutrub.src: W: spelling-error Summary(en_US) conjuagtion -> conjugation, conjuration, continuation python-libqutrub.src: W: spelling-error %description -l en_US conjuagtion -> conjugation, conjuration, continuation python-libqutrub.src: W: strange-permission LibQutrub-1.0.zip 0600L 2 packages and 0 specfiles checked; 0 errors, 6 warnings. + Source verified with upstream as (sha256sum) srpm tarball: c10d6e1d101026920060d2b8d921debcdfaaf795bd3c7241278e357415e942c1 upstream tarball : c10d6e1d101026920060d2b8d921debcdfaaf795bd3c7241278e357415e942c1 + License is just "GPL+" as per PKG-INFO suggestions: 1) Email to upstream author and get clarification on what is the license for this python module. When you get reply you can include that reply as a LICENSE file as Source1: in spec and add it to %doc 2) I failed to understand the meaning of following line #Site of files just for including: instead of this you can include like "Remove the python shebang" 3) you need to follow https://fedoraproject.org/wiki/Packaging:Python guidelines Add in %prep after setup macro line rm -rf *.egg-info this is to make sure you will not install directly egg info file that upstream if providing and instead you are installing egg info that gets created in %build section 4) As per python guidelines your %install section should use %{__python2} setup.py install --skip-build --root=%{buildroot} 5) your %files section should look like this %files -n python-%{module_name} %doc PKG-INFO %{python2_sitelib}/%{modname}/ %{python2_sitelib}/%{distname}-%{version}-py2.*.egg-info 6) License tag can be just "GPL+" as there is no mention of any GPL version information but good to ask upstream. Note: We need some reference that will show what is the license for this package. 7) Group tag is optional so you can remove it for fedora releases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review