[Bug 1060520] Review Request: qm-vamp-plugins - Vamp audio feature extraction plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1060520

Martin Milata <mmilata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |valtri@xxxxxxxxxx
              Flags|                            |needinfo?(valtri@xxxxxxxxxx
                   |                            |)



--- Comment #1 from Martin Milata <mmilata@xxxxxxxxxx> ---
Only found one issue: [1] says that "Packages which explicitly need to link
against the static version must BuildRequire: foo-static, so that the usage can
be tracked.", however qm-vamp-plugins buildrequire qm-dsp-devel. I guess the
spec should be more explicit about linking against static libraries and require
qm-dsp-static instead.

Otherwise looks good and when mixxx is run with VAMP_PATH=/usr/lib64/vamp/ the
options "Tempo and Beat Tracker" appears in the list of beat analysers. I guess
this means that the package functions as described:)

[1]
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries_2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]