Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: autodownloader - GUI-tool to automate the download of certain files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238366 dev@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dev@xxxxxxxxxx 2007-04-30 16:23 EST ------- Package name: OK (autodownloader) License: OK (GPL) Spec Legible: OK (en_US) md5sum matches: OK (5ec9b35266be518b8384a7fea581680c) rpmlint clean: OK Builds correctly: OK (noarch) Spec has %clean: OK Macro use consistant: OK Contains code/content: OK -doc subpackage: NA -devel subpackage: NA -static subpackage: NA pkgconfig depend: NA Contains %doc: OK (COPYING ChangeLog GladeWindow-license.txt README.txt TODO example.autodlrc) Library suffix: NA No .la files: NA Use desktop-file-install: NA No duplicate ownerships: OK rm -rf %{buildroot}: OK RPM uses valid UTF-8: OK %defattr is set: OK No duplicate %files: OK Not relocatable: OK Calls ldconfig: NA Supports Locales: NA BR's are correct: OK Other notes: * Builds in mock (obviously) * I have not been able to test but it appears to be okay * As downloaded files are written to home, it's generally not rpm's responsibility to cleanup (but the users) * When downloads start going to /usr then autodownloader should provide some way of deleting on uninstall. APPROVED (p.s. Any chance you could take a look at ocamlSDL (235804)? I've still got to get camlimages & windowlab back in shape but that one is ready) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review