https://bugzilla.redhat.com/show_bug.cgi?id=1149649 Andrea Musuruane <musuruan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |musuruan@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |musuruan@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Andrea Musuruane <musuruan@xxxxxxxxx> --- Correct SRPM URL seem to be: https://raphgro.fedorapeople.org/review/tuxfootball/tuxfootball-0.3.1-0.1.fc20.src.rpm I'm using this one to perform the review. Release tag is wrong. You are using a pre-release tag but tuxfootball-0.3.1 has been released. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag Better, more descriptive, summary: "Great 2D soccer (sometimes called football) game" License is wrong. It is "GPLv2+" (note the +) not "GPLv2". Source0 URL is wrong. It should be: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net In this way you can get rid of the %{ver} macro. Guidelines require to "Requires:" a package when you install a file into a directory that the package does not own. You install icons into /usr/share/icons/hicolor and therefore you MUST "Requires: hicolor-icon-theme". https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership You must use trademarks in a way that is not ambiguous. Avoid phrasing like "similar to" or "like". Therefore avoid using "Amco's Kick Off" and "Sensible Software's Sensible Soccer" in description. https://fedoraproject.org/wiki/Packaging:Guidelines#summary You can improve the description adding: The gameplay is designed to be quick, responsive and fun. You are always in control of the player closest to the ball. The ball is controlled via two different kick buttons - one for pass, and one for shoot. Aftertouch can be applied to shots by quickly pressing and holding the direction you want the ball to bend towards. Pushing in the opposite direction to what you kicked the ball makes it raise into the air, pushing in the same direction as the ball makes it dip towards the ground. You MUST use scriptlets to update the icon cache to ensure that the Desktop files are able to load the included icon files. https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Because the data package is build from the same source as the main package, there is no real gain in splitting them apart. You can use %{_pkgdocdir} instead of %{_docdir}/%{name} Remove ChangeLog from docs. It is irrelevant documentation (it is about source code commits) and it should not be packaged. https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation The package uses gettext for translations so you should add "BuildRequires: gettext". Moreover, you MUST use the %find_lang macro. https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Compilation is not verbose. Therefore it is not possible to check the compiler flag used. Invoke make like "make %{?_smp_mflags} V=1" Incorrect FSF addess should be reported upstream. https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/tuxfootball-0.3.1/src/SFont.c tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/tuxfootball-0.3.1/src/SFont.h tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/tuxfootball-0.3.1/src/Font.hpp I'll perform a deeper analysis after these issues are fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review