https://bugzilla.redhat.com/show_bug.cgi?id=1152653 --- Comment #9 from Scott Talbert <swt@xxxxxxxxxx> --- > gcc %{?__global_ldflags} -fPIC -shared -Wl,-soname,%{soname} \ > %{name}.o -o lib%{name}.so.0.1 One nit, I think you could use your soname global on the 2nd line here. The only other issue from the package review is the precompiled binaries in the source bundle. I'm not sure why it matters, since it is clear they aren't going into the RPM, but the guidelines state they must be removed in %prep. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review