[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1150666



--- Comment #2 from Jan Synacek <jsynacek@xxxxxxxxxx> ---
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Swig wrapper libraries, I don't see a problem with that.

[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gnuradio,
     /usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks

These are owned by gnuradio, which is required for this package.

[!]: Reviewer should test that the package builds in mock.

It builds. I've built the package myself, because one of the required
libraries wasn't available in the rawhide build root (it's built
properly though, just not propagated yet).

[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-iqbal-
     devel , gr-iqbal-doc

ACTION REQUIRED: Please, add %{?_isa} to the devel subpackage.

Rpmlint
-------
Checking: gr-iqbal-0.37.2-1.fc22.x86_64.rpm
          gr-iqbal-devel-0.37.2-1.fc22.x86_64.rpm
          gr-iqbal-doc-0.37.2-1.fc22.noarch.rpm
          gr-iqbal-0.37.2-1.fc20.src.rpm
gr-iqbal-devel.x86_64: W: only-non-binary-in-usr-lib
gr-iqbal-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

No problem, the first warning is a known bug.

Unversioned so-files
--------------------
gr-iqbal:
/usr/lib64/python2.7/site-packages/gnuradio/iqbalance/_iqbalance_swig.so

Swig wrappers, no problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]