https://bugzilla.redhat.com/show_bug.cgi?id=1152653 --- Comment #3 from Scott Talbert <swt@xxxxxxxxxx> --- A few initial comments. > Release: 0.1.%{miniz_rc}%{?dist} I'm thinking this should just be 1.%{miniz_rc}%{?dist} since this is a post-release (ie, 1.15r4 came after 1.15) rather than a pre-release. See here: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease > gcc %{?__global_ldflags} -fPIC -shared %{name}.o -o lib%{name}.so I'm wondering if we should be adding soname versioning? It doesn't seem like upstream is changing much but it seems like it might be good to have. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review