[Bug 226209] Merge Review: nut

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=226209



--- Comment #10 from Michal Hlavinka <mhlavink@xxxxxxxxxx> ---
(In reply to Vitezslav Crhonek from comment #9)
> Sorry for (very) late response.
> 
> rpmlint: 
> ./nut.spec:125: W: macro-in-comment %patch4
> ./nut.spec:131: W: macro-in-comment %patch10
> ./nut.spec:132: W: macro-in-comment %patch11
> ./nut.spec: W: patch-not-applied Patch4: nut-2.6.5-ipmifix.patch
> 
> Any reason to not apply Patch4?

it was required for new release of freeipmi that broke api (patch), got
reverted (disabled patch) and released new version with compatible api (patch
no longer needed)

I've removed it

> Patches number 10 and 11 are not defined at all, removing comments with them
> will do no harm.

done

> ./nut.spec:387: E: hardcoded-library-path in
> /lib/systemd/system-shutdown/nutshutdown
> 
> Isn't it possible to use some rpm macro here?

there is no usable macro for this, afaik there are only 2 packages using this
path, so probably insufficient demand :)

> nut-client.x86_64: W: one-line-command-in-%postun /sbin/ldconfig

modified

> nut-devel.x86_64: E: incorrect-fsf-address /usr/include/nutscan-ip.h

I will notify upstream, but won't patch it myself. Not worth it

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]