[Bug 1152246] Review Request: joda-timezones - Timezone data for joda-time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1152246



--- Comment #2 from Mo Morsi <mmorsi@xxxxxxxxxx> ---
Thx for review. Mostly copy-n-paste errors.

Spec URL: https://mmorsi.fedorapeople.org/staging/joda-timezones.spec
SRPM URL:
https://mmorsi.fedorapeople.org/staging/joda-timezones-2013d-2.fc20.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7864861

(In reply to Michael Simacek from comment #1)
> Issues:
> - Upstream URL doesn't exist
> - Source0 URL doesn't exist
> - Missing BR exec-maven-plugin and joda-time
> - Missing period at the end of description

Fixed all of these

> - Undetermined license - ask upstream to include it

https://github.com/jruby/joda-timezones/issues/2

> - Incorrect changelog format - missing version-release
> - Group tag is obsolete, remove it

Fixed these

> - Outdated timezone data (2013)

This is what the upstream release uses so figure it'd best to go w/ this to
mitigate any unexpected consequences.


> - Spec file as given by url is not the same as in SRPM

Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]