https://bugzilla.redhat.com/show_bug.cgi?id=1151462 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> --- good to see that you used fedora-review first on your own package before reviewing other people's packages. As you can see you need some fixes in your package to follow packaging guidelines. But before that I see you are also upstream for what you have packaged. So, I got some suggestions. If upstream is good in generating good releases then it becomes easy for us to package it in fedora. 1) I see you already host your source on github. Its good to create tarball of your source files which will contain files belen.rb belen.svg README -> this will provide information about what this source is and how can one use it. LICENSE -> Always good to add a single license text for all your source files. belen.desktop -> desktop file Makefile -> This will install the above files on the system. This will make your spec more simple instead to add every source files and then desktop file contents in spec. 2) your desktop file should look like [Desktop Entry] Name=Belen Comment=Belen is a GUI of command youtube-dl for Linux Icon=/usr/share/pixmaps/belen.svg Type=Application Categories=Video;AudioVideo; Exec=/usr/bin/belen StartupNotify=true Terminal=false See http://standards.freedesktop.org/menu-spec/latest/apa.html for valid categories. 3) when you want to install desktop file, follow guidelines https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage 4) As given by fedora-review Package uses either %{buildroot} or $RPM_BUILD_ROOT but in this package spec both %{buildroot} and $RPM_BUILD_ROOT are used. See more http://fedoraproject.org/wiki/Packaging/Guidelines#macros 5) you should not install icon file in /usr/share/icons directory but in /usr/share/pixmaps 6)As per ruby packaging guidelines you should Requires: ruby(release) and remove Requires: for ruby and python both are not needed 7) It is now optional and should not be added following lines for fedora packaging Group:Applications/Multimedia rm -rf $RPM_BUILD_ROOT %defattr(755, root, root) you can read about this in https://fedoraproject.org/wiki/Packaging:Guidelines You can submit new spec and srpm fixing above issues for further review of this package. Note you should bump release tag and add changelog for what you changed in spec file since its last release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review