https://bugzilla.redhat.com/show_bug.cgi?id=1151855 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/pear/Date/Holidays/Filter/Austria [!]: Requires correct, justified where necessary. => missing php-date (see phpci.log) [!]: Each %files section contains %defattr if rpm < 4.4 [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or => For consistency, if EPEL-5 is planed, add rm -rf ... in %install if EPEL-5 is not planed, clean the others [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. => PHP License is mandatory per license term (BSD like). => File a upstream bug + add link to this bug => You can add the file to the package (link in the headers) About # pear.php.net has interesting packaging habits! %{__tar} -xif %{SOURCE0} => This is not a pear habit, but a corrupted archive (known bug with old Archive_Tar version) => File a bug upstream and add link in the spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review