[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080203



--- Comment #6 from David Dick <ddick@xxxxxxxx> ---
Builds successfully at
http://koji.fedoraproject.org/koji/taskinfo?taskID=7857678

License is correct

You need to add all the perl modules that are used during the build, test and
install cycles.  In this case, all the perl modules when running "perl
Makefile.PL && make && make test && make install"

Therefore, add the following BRs

BR: perl(Exporter) # in lib/Test/Excel/Template/Plus.pm at line 15
BR: perl(File::Spec::Functions) # in t/001_basic.t at line 7
BR: perl(Test::Pod) >= 1.14 # in t/pod.t at line 8
BR: perl(Test::Pod::Coverage) >= 1.04 # in t/pod_coverage.t at line 8
BR: perl(Moose::Util::TypeConstraints) # in lib/Excel/Template/Plus/TT.pm at
line 4 
BR: perl(strict) # in t/000_load.t at line 3
BR: perl(Test::Builder) # in lib/Test/Excel/Template/Plus.pm at line 8
BR: perl(warnings) # in t/000_load.t at line 4

Remove the following BRs

BR: perl(Module::Build) # you are using Makefile.PL, there is no need for
Module::Build.
BR: perl(File::Spec) # there is no reference to File::Spec, only
File::Spec::Functions, therefore, include File::Spec::Functions explicitly, rpm
will make the connection to install File::Spec
BR: perl(Test::More) # there are two separate instances in BuildRequires. 
Remove one

Remove the following RunTime requires

Requires:       perl(Excel::Template)
Requires:       perl(IO::String)
Requires:       perl(Spreadsheet::ParseExcel)
Requires:       perl(Template)
Requires:       perl(Test::Deep)

as these are automatically detected

Add the following lines just before the %description line

%global __requires_exclude
%{?__requires_exclude:__requires_exclude|}^perl\\(Moose\\)$
%global __requires_exclude %__requires_exclude|^perl\\(MooseX::Param\\)$

as your explicitly versioned run time requires make the generic requires
unnecessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]