https://bugzilla.redhat.com/show_bug.cgi?id=1060519 Martin Milata <mmilata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@xxxxxxxxxx Flags| |needinfo?(valtri@xxxxxxxxxx | |) --- Comment #4 from Martin Milata <mmilata@xxxxxxxxxx> --- Looks pretty good! The only guideline not followed I've been able to find is "All patches should have an upstream bug link or comment"[1] - can you submit qm-dsp-cxx-build.patch (or does [2] do the same?) and qm-dsp-install.patch upstream and include a link/comment? Also, it makes sense to try to be close to upstream but can you perhaps open an upstream bug for supporting shared library builds (provided qm-vamp-plugins can use it)? [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment [2] https://code.soundsoftware.ac.uk/projects/qm-dsp/repository/revisions/915365c58758 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review